search

infor-design / enterprise

Enterprise-grade component library for the Infor Design System
https://design.infor.com
Apache License 2.0
134 stars 81 forks source link

application menu dismissOnClickMobile false doesn't work on mobile #1627

Closed ahnpnl closed 4 years ago

ahnpnl commented 5 years ago

Describe the bug Try to set dismissOnClickMobile to false but application menu still closes when clicking outside the menu on small screens/mobile screens

To Reproduce Steps to reproduce the behavior:

  1. Start example app inside enterprise-ng repo
  2. Go to app.component.html and modify [dismissOnClickMobile] to be [dismissOnClickMobile]="false"
  3. Open chrome dev tool and use device simulator and choose a phone, e.g iPhone 8
  4. Click on hamburger icon to open menu and then click outside the menu. Observe that menu closes.

Expected behavior dismissOnClickMobile false value shouldn't close the menu when clicking outside the menu. Or is it a misleading regarding to this option

Version

Screenshots N.A.

Platform

Additional context There should be at least some documentations about this option.

tmcconechy commented 5 years ago

I agree this is maybe a misleading option. What it does is close the menu when you select a menu item by clicking it (or not). The menu is always cancelled and dismissed when you click out. Im not sure why you would want to turn off being able to dismiss the menu by clicking out to cancel/remove it?

Maybe we just need to update the doco on this?

Can you move this to EP @clepore please?

ahnpnl commented 5 years ago

Hi Tim,

For an application in ION, we have a scenario image this modal dialog is opened by clicking on Settings menu. The requirement says when the users click on the slider inside this modal dialog, the menu shouldn't close.

I'll forward your answer above to the BA. Just let you know there is such a requirement like that.

tmcconechy commented 5 years ago

Ok, It probably shouldnt close if clicking anything on the modal. So thats probably an issue. I think the setting is right, we may just need to ignore any clicks on a modal if those are closing it.

I think we could make a sample to reproduce this.

tmcconechy commented 4 years ago

Descoping this issue for now