search

infor-design / enterprise

Enterprise-grade component library for the Infor Design System
https://design.infor.com
Apache License 2.0
133 stars 81 forks source link

DataGrid: Display issues when allow frozen columns to be resizable and column.colspan function exists #5194

Closed claudenbach closed 11 months ago

claudenbach commented 3 years ago

Describe the bug Display issues when allow frozen columns to be resizable and there exists column.colspan function.

Steps to reproduce the behavior:

  1. Using the attached test-frozen-columns-resizable-with-colspan.html or go to http://localhost:4000/components/datagrid/test-frozen-columns-resizable-with-colspan.html as its been commited
  2. In the browser zoom in once (view menu) to around 125%
  3. Resize the width of the Product Type column
  4. Notice the blank column area that appears as its resized

Expected behavior Allow frozen columns to be resizable even when a colspan exists. The colspan represents the number of columns to span irrespective of whether frozen columns exist.

Version

Screenshots image

tmcconechy commented 3 years ago

I'm guessing its going to be a time consuming/tricky one to fix.

claudenbach commented 3 years ago

Git-5115.zip

tmcconechy commented 3 years ago

@tmcconechy will have to prioritize this issue for landmark so adding to the sprint (i'm talking to myself 👍🏻 )

tmcconechy commented 3 years ago

@claudenbach i put in the example you gave me but i wasnt able to reproduce this. See my results:

https://drive.google.com/file/d/1ckpHJIW_iIRgiRsLqiUcB7vYABmB9ksx/view

claudenbach commented 3 years ago

I'm testing on v4.50.2 and still seeing the issue.

Git-5115

tmcconechy commented 3 years ago

Im testing on master which is 4.51-beta but it shouldn't be any different here... But i did try on windows and mac. And i definitely am using the new example. But not seeing this.

claudenbach commented 3 years ago

Let me test with 4.51-beta and use test-frozen-columns-resizable-with-colspan.html.

claudenbach commented 3 years ago

Testing with v4.51.0-beta and using test-frozen-columns-resizable-with-colspan.html, I'm not able to duplicate either!

tmcconechy commented 3 years ago

Yeah weird - i wasn't expecting this would be magically fixed but great. Can't think of anything we put in since then that would be related.

Will just mark this as fixed in 4.51 and send to QA for QA please test http://localhost:4000/components/datagrid/test-frozen-columns-resizable-with-colspan

claudenbach commented 3 years ago

Well, when changing the overall browser window size, then I'm able to duplicate.

But only on my laptop, not on my second monitor?

tmcconechy commented 3 years ago

I tried that on suspicion as well but it didn't come up for me. Maybe check the screen size in the elements tab in chrome dev tools and let me what dimension you see it? Any zoom enabled?

claudenbach commented 3 years ago

Git-5115-More-Testing

claudenbach commented 3 years ago

Is this what you were asking for? Otherwise perhaps just give a call?

image

tmcconechy commented 3 years ago

Maybe we better after lunch... I tried your size (yes thats what i meant) and i am not seeing it. But in your video looks like your doing a second action that i cant make out like it works the first time then your doing something else?

claudenbach commented 3 years ago

Sounds good. I'm unavailable today from 1:00pm to 2:00pm CST.

tmcconechy commented 3 years ago

https://main-enterprise.demo.design.infor.com/components/datagrid/test-frozen-columns-resizable-with-colspan.html now has your example...

tmcconechy commented 3 years ago

@claudenbach this fix is turning to be very tricky / risky and time consuming. Wondering if we can just restrict the resize in this scenario? I.E. If colspans and frozen columns disable resize on that column with the resizable option.

I think we might need to redo the resize logic entirely which is planned for the new Web Component project.

tmcconechy commented 3 years ago

Going to have to table this for now its too tricky. So parking this. Suggest doing a workaround by hiding the resize in this case of frozen + colspan) or "not zooming". We can come back to it when the Web component version is done.

lipetzan commented 3 years ago

Aging customer issue.. Do I read this as you won't pursue a fix?

tmcconechy commented 3 years ago

Yes, I was hoping that due to the amount of work for this issue will and risk and time it will take that we factor this in to the new component work and fix it then. For now maybe its possible to not combine column spanning and frozen columns and zooming.

This at minimum needs:

So it will be fixed eventually. But for now was hoping you could not combine this set of features.

If that doesnt work we can take another look for an "easier" solution...But i timeboxed this one and it seemed like it would be a lot of work

@lucacolumbu

lucacolumbu commented 3 years ago

We have looked into this and the fix would require a re architecture of the Datagrid, which given the risk and the resources, we can't afford right now. We will, however, make it a priority for the new Datagrid in the Web Components implementation.

tmcconechy commented 2 years ago

For next sprint can you take another look at this issue @ericangeles i want to make sure someone else tries this as i could not find a solution without changing the grid to a set of divs which is a Huge change.

See if you can find a simple solution if not lets discuss and we'll have to go to fixing it in the next version...

FinCheng commented 1 year ago

@tmcconechy Hi Tim, Do you have any plan to fix this issue, we hit this issue as well.

tmcconechy commented 1 year ago

When we discussed it before we thought the combination was a bit strange and uncommon. Whats the use case? Can you avoid combining colspan and frozen? And avoid reszing frozen columns?

tmcconechy commented 11 months ago

Descoping this one as its rather old and no bandwidth. Maybe in the new version if still needed. Will need more info on use cases