Open kwolentarski opened 5 months ago
@kwolentarski the lineage is for trees, so is it really needed in non trees? Will be a lot of work to add it to every event safely.
I'm more than fine with not using lineage in postRenderCell, that was just example of a case where the row is different. In some cases we would still like to use trees, and have those methods return consistently the row index.
In our current use case we are using onPostRenderCell, onDestroyCell and formatter together in Angular to cache the components instead of recreating them. Key for this cache is depending on the row value passed to those events, so we need it to be consistent in order for it to work properly. I think aria-rowindex is the most unique one and consistent, so maybe this one is a good candidate.
@kwolentarski I think what we need is a test case we can use for this? Could you give me an example of onPostRenderCell and onDestroyCell? Are they NOT omitting the data.
Having a bit of an issue scoping this one as "various" when i think we need more exact cases? We added the code quality label because im not clear if its broken for what it omits or this is a general code quality suggestion.
Describe the bug
Currently datagrid methods are not consistent with the way they calculate row identifier. Examples:
Expected behavior The row index passed for methods/events should be consistent across whole datagrid
Version
Platform