infor-design / enterprise

Enterprise-grade component library for the Infor Design System
https://design.infor.com
Apache License 2.0
130 stars 77 forks source link

8635 - Correct Demo App So Fonts Are Served #8676

Closed tmcconechy closed 1 week ago

tmcconechy commented 2 weeks ago

Explain the details for making this change. What existing problem does the pull request solve?

Because of GDPR and banned googleapis in china, we changed all the docs and sample app to use a self hosted font instead of the google api URL.

Related github/jira issue (required): Fixes #8635 Fixes #8671

NOTE: Do not merge until told as we are checking some things with compliance team

Steps necessary to review your pull request (required):

Included in this Pull Request:

n-ace-ancog commented 1 week ago

Seems like the current branch has bigger fonts than with main. They are both in 100% zoom. Is this expected?

http://localhost:4000/components/locale/test-translations.html?locale=zh-Hant

https://github.com/infor-design/enterprise/assets/156752175/a5c2426f-33d1-47a7-98d0-699b526f2dc3

tmcconechy commented 1 week ago

@n-ace-ancog yes, there is a difference i should have mentioned with the language fonts. They were not working before so it was using a different font now.