search

informalsystems / basecoin-rs

An example ABCI application making use of tendermint-rs and ibc-rs
Apache License 2.0
56 stars 17 forks source link

Add integration test for testing client recovery #176

Closed seanchen1991 closed 6 months ago

seanchen1991 commented 6 months ago

Closes: #173

rnbguy commented 6 months ago

btw, for Cargo.toml formatting - are you using taplo?

if yes, let's use the following taplo.toml

include = ["**/Cargo.toml"]

[formatting]
align_entries = true
compact_arrays = false
array_auto_expand = false
array_auto_collapse = false
seanchen1991 commented 6 months ago

are you using taplo?

I'm not; I haven't heard of it before. Do you think we should add it?

rnbguy commented 6 months ago

Ah. I suggested as I saw you formatted the Cargo.tomls.

rnbguy commented 6 months ago

Looks like recovery-client has a different issue - it is halting basecoin (compared to #177 where upgrade-client halts gaiad). Here is the log

2024-04-23T12:56:19.945798Z DEBUG basecoin_app::abci::v0_37::impls: Got deliverTx request: RequestDeliverTx { tx: b"\n\x80\x01\ny\n$/ibc.core.client.v1.MsgRecoverClient\x12Q\n\x0f07-tendermint-1\x12\x0f07-tendermint-0\x1a-cosmos12xpmzmfpf7tn57xg93rne2hc2q26lcfql5efws\x12\x03ibc\x12g\nP\nF\n\x1f/cosmos.crypto.secp256k1.PubKey\x12#\n!\x02\xf3\xa3\x03\x02\xf4\xcb?1\xca\xf5UGq\xb5N]5\x8f3q\xc5z\xb5F[\xf0\x11\xeb\xd7vyr\x12\x04\n\x02\x08\x01\x18\x12\x12\x13\n\r\n\x05stake\x12\x044000\x10\x80\xb5\x18\x1a@\x80\xc5\xe6Q@ \xbc\xf7'\x91l6r\xf5\x13)\xba\x01\x08;\x96\x9f\x02\xfd\xdf\xfb\xcd\xf9K\xe9\xc9@*IR\x8d\x86\x12\xa5\xaa\x84\xdf\xc4pB\x05\xa3\x8e\xf8\xcc\xb2\x12\x11\xd9\x90#\xca\xc5\x1d\xf1;\x99]\xef" }
2024-04-23T12:56:19.946227Z TRACE basecoin_store::impls::in_memory: get at path = cosmos12xpmzmfpf7tn57xg93rne2hc2q26lcfql5efws at height = Pending
2024-04-23T12:56:19.946339Z TRACE basecoin_store::impls::in_memory: set at path = cosmos12xpmzmfpf7tn57xg93rne2hc2q26lcfql5efws
2024-04-23T12:56:19.946513Z TRACE basecoin_store::impls::revertible: Rollback operation log changes
2024-04-23T12:56:19.946535Z TRACE basecoin_store::impls::in_memory: set at path = cosmos12xpmzmfpf7tn57xg93rne2hc2q26lcfql5efws
2024-04-23T12:56:19.946598Z TRACE basecoin_store::impls::in_memory: set at path = cosmos12xpmzmfpf7tn57xg93rne2hc2q26lcfql5efws
2024-04-23T12:56:19.946656Z TRACE basecoin_store::impls::in_memory: set at path = cosmos12xpmzmfpf7tn57xg93rne2hc2q26lcfql5efws
2024-04-23T12:56:19.946714Z TRACE basecoin_store::impls::in_memory: set at path = cosmos12xpmzmfpf7tn57xg93rne2hc2q26lcfql5efws
(...non-termination...)

Since the transaction fails, the store tries to rollback - but hits #129

rnbguy commented 6 months ago

The basecoin binary is accessed as following in upgrade-client.sh:

https://github.com/informalsystems/basecoin-rs/blob/3b8272fff95928f927e0d7026d23e7e222f85d8d/ci/tests/upgrade-client.sh#L4

rnbguy commented 6 months ago

I fixed the transaction failure. We needed to submit it as a governance proposal. But now the client is updated (even I can see the updated client state) - yet the client status is returned as expired.

rnbguy commented 6 months ago

Takes the latest commit from cosmos/ibc-rs#1197 to make sure e2e tests pass at basecoin-rs side :rocket: