First draft spec rate limiter

informalsystems / interchain

This repository is purely experimental. It is meant to track cross-stack issues. These are issues which we do not know where they belong (is it a Tendermint? an SDK? an IBC-go problem?) or which have multiple dependencies in different repositories, potentially across multiple organizations (cosmos, informalsystems).

0 stars 0 forks source link

First draft spec rate limiter #4

Closed angbrav closed 1 year ago

angbrav commented 1 year ago

Rendered

Transforms this informal doc into a bit more formal spec.

Includes pseudocode
Some text descriptions

~~It would be nice to adapt the spec to implement the Middleware interface specified in ICS 30.~~ AS: Update: I captured this as a known limitation inside the spec.

ancazamfir commented 1 year ago

Just noticed the two figures have different types (.svg vs .png) and also the fonts are different. We should fix this.

angbrav commented 1 year ago

I did a full pass. Main changes (please review):

add definitions of native token and source chain
make FlowPath a triplet: this includes going through the text, adapting the pseudocode, etc
say in the limitations section that the functions for setting, changing and removing ratelimiters are not specified

I have also left a comment w.r.t. to a question that I have with the sendPacket pseudocode. Other than that, I am fine with the version.

angbrav commented 1 year ago

Just noticed the two figures have different types (.svg vs .png) and also the fonts are different. We should fix this.

It would be nice to fix, but should not be a blocker to getting this merge I believe.

ancazamfir commented 1 year ago

Just noticed the two figures have different types (.svg vs .png) and also the fonts are different. We should fix this.

It would be nice to fix, but should not be a blocker to getting this merge I believe.

I made the change as it was very simple.

angbrav commented 1 year ago

Merging! great work!