informalsystems / quint

An executable specification language with delightful tooling based on the temporal logic of actions (TLA)
Apache License 2.0
790 stars 31 forks source link

Improve our tests that use fixtures #1422

Open bugarela opened 5 months ago

bugarela commented 5 months ago

Ideas:

  1. Format test fixture json file as suggested by @p-offtermatt in https://github.com/informalsystems/quint/pull/1421#pullrequestreview-1985582480, this would make the diffs much easier to read (currently impossible to read)
  2. Use a proper snapshot lib to handle these.
bugarela commented 2 weeks ago

We could take advantage of jd, which shows formatted json difference:

git show main:quint/testFixture/_1016nonConstOverride.json | jd testFixture/_1016nonConstOverride.json
@ ["table","8","id"]
- 6
+ 2

But we should first check if there are any snapshot tools - I want to avoid having to maintain the tool in house, even if its simple.