Currently, when generating a new Tendermint header from a testgen Header, the app_hash field is set to an empty string value. This leads to a nil root when using this header to obtain consensus states (e.g. like here in basecoin-rs), which is not an acceptable value for ibc-rs implementation, resulting in the rejection of submitted consensus states to an IBC module.
Definition of "done"
To address this, it is recommended to add an app_hash field to the testget Header. While the default value can remain empty, this would allow users the flexibility to introduce their desired app_hash when necessary, as used here for implementing a mock cosmos chain.
Description
Currently, when generating a new Tendermint header from a testgen
Header, theapp_hashfield is set to an empty string value. This leads to a nil root when using this header to obtain consensus states (e.g. like here inbasecoin-rs), which is not an acceptable value foribc-rsimplementation, resulting in the rejection of submitted consensus states to an IBC module.Definition of "done"
To address this, it is recommended to add an
app_hashfield to the testgetHeader. While the default value can remain empty, this would allow users the flexibility to introduce their desiredapp_hashwhen necessary, as used here for implementing a mock cosmos chain.