informalsystems / tendermint-rs

Client libraries for Tendermint/CometBFT in Rust!
Apache License 2.0
588 stars 215 forks source link

rpc: replace `hyper::Client` with `reqwest::Client` #1362

Closed mzabaluev closed 9 months ago

mzabaluev commented 9 months ago

Closes #1342

In hyper, the high-level Client implementation is going to be removed in the next major release. The current client lacks built-in support for HTTP proxies, and we want to ditch hyper-proxy as it is unmaintained and its webpki dependency has a known security issue.

codecov-commenter commented 9 months ago

Codecov Report

Merging #1362 (c5f186d) into main (89da5f6) will decrease coverage by 0.6%. The diff coverage is 62.2%.

:exclamation: Current head c5f186d differs from pull request most recent head 7f9b850. Consider uploading reports for the commit 7f9b850 to get more accurate results

@@           Coverage Diff           @@
##            main   #1362     +/-   ##
=======================================
- Coverage   60.7%   60.2%   -0.6%     
=======================================
  Files        274     274             
  Lines      26864   27199    +335     
=======================================
+ Hits       16322   16386     +64     
- Misses     10542   10813    +271     
Files Coverage Δ
rpc/src/client/transport/auth.rs 100.0% <100.0%> (ø)
rpc/src/error.rs 95.2% <100.0%> (-0.1%) :arrow_down:
rpc/src/rpc_url.rs 66.6% <76.0%> (ø)
rpc/src/client/transport/websocket.rs 63.9% <15.3%> (-0.4%) :arrow_down:
rpc/src/client/transport/http.rs 34.5% <60.3%> (+14.4%) :arrow_up:

... and 5 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

romac commented 9 months ago

Love all that deleted code 🥇