informalsystems / tendermint-rs

Client libraries for Tendermint/CometBFT in Rust!
Apache License 2.0
588 stars 215 forks source link

rpc: Add `FromStr`, `Serialize` and `Deserialize` instances to `CompatMode` #1367

Closed romac closed 3 months ago

romac commented 8 months ago

Closes: #1374

codecov-commenter commented 8 months ago

Codecov Report

Merging #1367 (2b9c024) into main (bcc0b37) will increase coverage by 0.0%. The diff coverage is 71.7%.

:exclamation: Current head 2b9c024 differs from pull request most recent head eb7ff64. Consider uploading reports for the commit eb7ff64 to get more accurate results

@@          Coverage Diff          @@
##            main   #1367   +/-   ##
=====================================
  Coverage   61.2%   61.2%           
=====================================
  Files        274     274           
  Lines      26844   26890   +46     
=====================================
+ Hits       16433   16466   +33     
- Misses     10411   10424   +13     
Files Coverage Δ
rpc/src/error.rs 95.6% <100.0%> (+0.2%) :arrow_up:
rpc/src/client/compat.rs 79.3% <63.8%> (-10.9%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

romac commented 8 months ago

Looks like the test coverage job is failing because of changes in supported unstable flags on nightly:

error: failed to run `rustc` to learn about target-specific information
error: unknown unstable option: `instrument-coverage`