Closed tony-iqlusion closed 8 months ago
Merging #1370 (e91b0b4) into main (bcc0b37) will not change coverage. The diff coverage is
87.5%
.:exclamation: Current head e91b0b4 differs from pull request most recent head 7da8183. Consider uploading reports for the commit 7da8183 to get more accurate results
@@ Coverage Diff @@
## main #1370 +/- ##
=====================================
Coverage 61.2% 61.2%
=====================================
Files 274 274
Lines 26844 26844
=====================================
Hits 16433 16433
Misses 10411 10411
Files | Coverage Δ | |
---|---|---|
p2p/src/secret_connection.rs | 85.5% <100.0%> (ø) |
|
test/src/test/unit/p2p/secret_connection.rs | 100.0% <100.0%> (ø) |
|
p2p/src/secret_connection/protocol.rs | 59.8% <50.0%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
The
tendermint-p2p
crate previously pulled in both an obsolete version ofx25519-dalek
/curve25519-dalek
, but alsocurve25519-dalek-ng
by way ofed25519-consensus
.This replaces
x25519-dalek
withcurve25519-dalek-ng
which is already a dependency ofed25519-consensus
. This reduces the overall number of dependencies and ensurescurve25519-dalek-ng
is the main Curve25519 implementation used.Note: I don't have an open issue for this but since it reduces the overall number of dependencies I thought it made sense.
.changelog/