informalsystems / tendermint-rs

Client libraries for Tendermint/CometBFT in Rust!
Apache License 2.0
588 stars 215 forks source link

Avoid enabling flex-error/eyre_tracer feature #1371

Closed mina86 closed 8 months ago

mina86 commented 8 months ago

Don’t enable flex-error/eyre_tracer feature in crates which don’t use eyre directly. This allows customers depend on say tendermint crate without having to pull in eyre crate. This is useful because eyre uses mutable static variables (specifically HOOK variable) which is incompatible with some blockchain runtimes.

mina86 commented 8 months ago

@romac

romac commented 8 months ago

Good catch! Thanks