Closed mzabaluev closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
62ddb98
) 58.6% compared to head (4777142
) 60.2%.:exclamation: Current head 4777142 differs from pull request most recent head a9486b3. Consider uploading reports for the commit a9486b3 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
ideally the buffer management would be changed so this library allocates the buffer and
DATA_MAX_SIZE
is just a sanity limit
The protocol always sends full AEAD frames, and long messages are split between successive frames, with the last frame padded. So, regardless of what the doc comment says, DATA_MAX_SIZE
only defines the size of the encrypted frames. In plaintext, the message is length-prefixed.
The code handling chunking of data frames longer than the configured maximum was faulty.
May fix #1392 and possibly other occurrences of data corruption.
.changelog/