Closed cratelyn closed 3 months ago
Attention: Patch coverage is 11.53846%
with 23 lines
in your changes are missing coverage. Please review.
Project coverage is 59.3%. Comparing base (
99ed0b9
) to head (a1bce2c
).:exclamation: Current head a1bce2c differs from pull request most recent head 34e0c13. Consider uploading reports for the commit 34e0c13 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
currently, when working with
tendermint::{PrivateKey, PublicKey}
, users of theed25519-consensus
crate must convert aed25519_consensus::VerificationKey
ored25519_consensus::SigningKey
viaTryFrom<&'_ [u8]>
. this has the unfortunate effect of requiring a bounds check, on a value that is already known to be a valid key.this branch introduces some additional
From<T>
implementations, to facilitate free conversions fromed25519-consensus
types.PrivateKey
isFrom<ed25519_consensus::SigningKey>
SigningKey
isFrom<ed25519_consensus::SigningKey>
PublicKey
isFrom<ed25519_consensus::VerificationKey>
VerificationKey
isFrom<ed25519_consensus::VerificationKey>
an internal
SigningKey::new()
constructor is also added, for the sake of consistency withVerificationKey::new()
. this is optional, i'd be happy to back out of that change if it seems prudent.some additional
from_ed25519_consensus
methods are provided, for cases where type inference might not suffice. these felt complimentary to existing methods likefrom_raw_ed25519
, but are another optional change i'd be happy to back out of.