FinalizeBlock Response Deserialization Bug

informalsystems / tendermint-rs

Client libraries for Tendermint/CometBFT in Rust!

Apache License 2.0

587 stars 213 forks source link

FinalizeBlock Response Deserialization Bug #1427

Closed ec2 closed 4 weeks ago

ec2 commented 1 month ago

What went wrong?

CometBFT returns Null in the JSON response if there is no validator_updates. Proposed Fix: Add #[serde(with = "serializers::nullable")] to validator_updates just like how EndBlock has it

informalsystems / tendermint-rs

FinalizeBlock Response Deserialization Bug #1427

What went wrong?

Steps to reproduce

Definition of "done"