search

informalsystems / tendermint-rs

Client libraries for Tendermint/CometBFT in Rust!
Apache License 2.0
609 stars 224 forks source link

Spurious errors in kvstore-test test suite #784

Open romac opened 3 years ago

romac commented 3 years ago

On both current master (2c880d2) and in #783, I am seeing some non-deterministic errors when running the tendermint test suite of the kvstore-test crate.

Steps to reproduce

From within the tools/kvstore-test directory, run the following commands a few times until an error appears:

  1. rm -rf /tmp/tendermint && mkdir /tmp/tendermint && docker run -it --rm -v "/tmp/tendermint:/tendermint" -p 26657:26657 tendermint/tendermint:v0.34.0 node --proxy_app=kvstore
  2. cargo test --test tendermint -- --nocapture

Errors seen so far

  1. thread 'rpc::transaction_subscription' panicked at 'assertion failed: res.total_count > 0', kvstore-test/tests/tendermint.rs:382:9
  2. rpc::commit' panicked at 'assertion failed: `(left == right)` left: `false`, right: `true`', kvstore-test/tests/tendermint.rs:146:9
thanethomson commented 2 years ago

I haven't seen any of these nondeterministic failures in a few months now (I think due to increases in the timeout durations in the tests).

@mzabaluev have you seen any such failures in the past month or so? If so they would originate from here.

mzabaluev commented 2 years ago

@mzabaluev have you seen any such failures in the past month or so?

Sorry, I have not been running tendermint-rs tests lately.