batch unlink of members in pure and binary association

[hongsudt]

For pure and binary association, there is no way to get to a full set of these entries. Users can only see what's shown under the related tables. We should mimic the multi-select add to provide multi-select delete.

In the delete case, it should direct users to those records that are currently associated with the main entities, allow users to select multiple entries, then click submit. On top of the related table in the record page, maybe we can have "Remove" or "Unlink" to trigger the batch delete flow.

[jrchudy]

Use "Remove" in the modal title instead of "unlink". The same goes for the "submission" button.

[jrchudy]

The changes for this issue have been merged into master. Reassigning to @hongsuda to verify and close.

[hongsudt]

@karlcz when you have a chance, please review this feature and close it.

[karlcz]

I tried to test this on synapse-dev. I went to https://synapse-dev.isrd.isi.edu/chaise/record/#1/Zebrafish:Cohort%20Analysis/RID=17AR and tried to remove items from the "Cohort" related entity section.

The modal lets me pick items and shows them in chicklets at the top. But, the remove button closes the modal and nothing else happens. I don't see any DELETE request on the server either.

[hongsudt]

I also find the plus button on the modal confusing. We should remove that button from the remove modal.

[RFSH]

One of the confusing parts of the implementation of batch-unlink that we reverted was the fact that users could remove the existing facet. I recently added the hidden support to facets in the url. Now you can have facets in your url that won't be merged in the faceting UX and users won't be able to remove them.

The reference that we are going to use for the modal picker should be the result of calling .hideFacets() on the related reference.

[jrchudy]

Related to issues #1060 and #1591 .

[jrchudy]

Enhancements that can be done before sending the delete request:

• [x] more specific reference for deletion
  • previously the request was based on the "filtered url", so if no filter was applied, all rows were being unlinked. Instead, iterate over the list of rows to unlink and use their "shortest keys" in the url to make sure the reference is specific to only the rows being "unlinked"
• [x] sanity check the data in ermrest before sending the delete request
  • send a get request to the url produced for delete and verify data is consistent with what the UI knows about
  • if deleting 10 rows, get request should return 10 matching rows etc.
• [x] change confirm delete dialog text to communicate number of rows being removed
  • current text for single delete:
    • "Are you sure you want to delete this?"
  • multi delete text:
    • "Are you sure you want to delete X rows?"

[jrchudy]

Changes that were discussed in our meeting on Tuesday regarding how to best handle batch deletion:

• create a new "delete" function in ermrestJS specific to deleting batch association references
  • [x] return from function instantly if reference is not defined, tuples is not defined, or tuples is length < 1
  • [x] instead of creating individual references and calling reference.delete(), write a function that uses http.delete with the proper ermrest path for each chunk of data to be deleted
  • [x] verify the data being used to create a path is defined and non-null
  • [x] verify the created paths can parse to a proper location object with at least one defined filter, which may be one or many filter predicates
  • [x] further verify created paths' filter(s) are based on the same uniqueness constraints for all rows to be deleted
  • [x] do deletion in sequence since ermrest doesn't like doing parallel mutations
    • collect all success and error responses in 2 arrays and return to calling site in chaise
• in chaise, check success and errors arrays
  • [x] all success (treat as the same as partial errors/success just there are no errors)
  • [x] some success and some errors
    • show alert modal describing the errors (and how many rows succeeded)
    • "5 rows unlinked successfully, but 5 other rows were not removed"
      • extra error details show the error that was returned (or errors)
    • "clicking ok refresh the data and see the updated list"
    • update data in the modal to reflect deleted rows (refetch rows and count) after modal close
    • after data updated, non-removed rows because of error should remain selected
    • user has control over modifying selections or can abort entirely by clicking cancel on p&b unlink modal
  • [x] all errors (same as partial errors)

To be done later:

• [ ] change unlink modal to remove checkboxes for rows that violate trs rights