informatics-isi-edu / deriva-qt

Graphical User Interface tools for DERIVA using PyQt
GNU General Public License v3.0
0 stars 1 forks source link

upload button disabled when default server config is incompatible with client app #10

Open robes opened 4 years ago

robes commented 4 years ago
  1. install some version of deriva-download app, let's say version 0.8
  2. connect to a couple servers, say staging.foo.org and dev.foo.org, where staging is the first/default
  3. update your upload spec for dev.foo.org, let's say to accept client version >=1.0 and <2.0
  4. next use of deriva-download it asks you update
  5. update your derive-download to 1.0
  6. restart deriva-download
  7. since staging is the first/default, it will immediately tell you you need to downgrade, but since you don't want to do that, hit cancel
  8. the browse button is disabled
  9. select dev.foo.org from the downdown
  10. login
  11. the browse button remains disabled
robes commented 4 years ago

I meant to add above that I am not blocked. I simply deleted the offending default spec and restarted the app.

Also, I have a couple thoughts:

  1. it might be worthwhile just letting the user attempt to use the spec if they chose rather than disabling the client. After a "use at your own risk" warning?
  2. at a minimum, it would be really good to allow the user to fetch the latest upload configuration. For instance, in this case, the revised config would allow my 1.0 client to work.
  3. or I suppose is there really an advantage over just deleting the offending config file and re-adding the server. Not sure.
robes commented 4 years ago

Well, at a minimum the client should only be disabled for the incompatible configurations, and even then, the client should be able to at least fetch updated configurations (in case it simply needs updating).