informatics-isi-edu / deriva-webapps

Deriva-based web applications
Apache License 2.0
2 stars 1 forks source link

React boolean search #149

Closed PoornimaVKrishnan closed 1 year ago

PoornimaVKrishnan commented 1 year ago

Resolved all comments. Please review again

jrchudy commented 1 year ago

When I write this query into the box: strength{in "anatomical source" FromStage..ToStage pt=pattern lc=location} AND strength{in "anatomical source" FromStage..ToStage pt=pattern lc=location}

It is being changed to when I click validate: {in '' trength{in "anatomical source" FromStage..ToStage pt=pattern lc=location} AND {in '' trength{in "anatomical source" FromStage..ToStage pt=pattern lc=location}

It looks like the s from strength is being replaced with {in '' upon clicking validate.

Checking with the old version of boolean search, I see that the text in the query box is not changing with an invalid query. But it is changing the strength, From, and To dropdowns to empty string ('')

Another difference I noticed when comparing the dropdowns after testing the above validation. This might be why the above isn't working properly to replace parts of the string:

jrchudy commented 1 year ago

The changes to fix the validation are working as we expect now. 2 issues that I found while messing around with the strength, To, and From dropdowns: