The main purpose of this PR is to add support for markdown in the raw value of comment APIs (#981). But instead of adding a separate commentRenderMarkdown, I changed .comment returned value to an object (similar to how .displayname works). This allows us also to remove .commentDisplay and have it as part of the object.
Other changes are,
Contextualized comment are now supported.
Fix the inheritance of comment_display from the parent catalog, schema, or table.
comment, comment_display, and comment_render_markdown can come from different levels and don't affect each other. Before, we used to only get the comment_display from where the comment was defined. But now comment_display can come from the column directive while the comment is derived from the table (or vice versa).
Moved the comment-related APIs of ForeignkeyRef and Key to getDisplay, similar to how we've done it on Table and Column.
Since I completely changed how the .comment API works in here, we have to merge this at the same time as the chaise one.
The main purpose of this PR is to add support for markdown in the raw value of
commentAPIs (#981). But instead of adding a separatecommentRenderMarkdown, I changed.commentreturned value to an object (similar to how.displaynameworks). This allows us also to remove.commentDisplayand have it as part of the object.Other changes are,
Contextualized
commentare now supported.Fix the inheritance of
comment_displayfrom the parent catalog, schema, or table.comment,comment_display, andcomment_render_markdowncan come from different levels and don't affect each other. Before, we used to only get thecomment_displayfrom where thecommentwas defined. But nowcomment_displaycan come from the column directive while thecommentis derived from the table (or vice versa).Moved the comment-related APIs of
ForeignkeyRefandKeytogetDisplay, similar to how we've done it onTableandColumn.Since I completely changed how the
.commentAPI works in here, we have to merge this at the same time as the chaise one.