informatics-isi-edu / ermrestjs

ERMrest client library in JavaScript
Apache License 2.0
4 stars 3 forks source link

modify hide_column_headers annotation #834

Closed RFSH closed 2 years ago

RFSH commented 4 years ago

This attribute is currently defined in the table-display annotation and can be used to hide the column headers on the record page. The changes that we should do regarding this attribute are:

update:

Implementing these changes will fix issue #1993 in chaise.

jrchudy commented 3 years ago

PR #868 has been merged into master. In chaise, this is only implemented for the record app (detailed context).

jrchudy commented 3 years ago

@RFSH should we keep this issue open because of the 2nd bullet point?

RFSH commented 3 years ago

Yes, I think so. And it's a very small change (I don't think it's worth creating an extra issue for it)

RFSH commented 2 years ago

I renamed hide_column_headers to hide_column_header in this commit. I didn't remove the old name and it should still work for backwards compatibility purposes.