Compact select association sub context

informatics-isi-edu / ermrestjs

ERMrest client library in JavaScript

Apache License 2.0

4 stars 3 forks source link

Compact select association sub context #943

Closed jrchudy closed 2 years ago

jrchudy commented 2 years ago

This PR adds new sub contexts to compact to allow for further control over display settings in each. The new contexts include:

compact/select/association
compact/select/association/link
compact/select/association/unlink
compact/select/foreign_key
compact/select/saved_queries
compact/select/show_more

This is being done to be consistent with changes being made in chaise to support configuration of individual search popup displays.

RFSH commented 2 years ago

@jrchudy I don't remember what we agreed on last time, but what about other variations of compact/select (for foreign key, or other popups)? And didn't we have different contexts for link and unlink?

P.S. You should update annotation.md and also do make all to make sure the new API is included in the api.md.

jrchudy commented 2 years ago

I added more contexts to align with the attached issue and added those to annotation.md. We didn't finalize on the names for each other the other search popups contexts, so I used what I wrote in the issue that Hongsuda saw before.

I noticed there was a compact/entry context in ermrestJS which I think is probably being used for foreign key popups, so I'm not sure what changes we should make regarding that. It seems like contextualize.compactEntry is only being called in ermrestJS code.