search

informatics-isi-edu / ermrestjs

ERMrest client library in JavaScript
Apache License 2.0
4 stars 3 forks source link

Asset image preview #973

Closed RFSH closed 1 year ago

RFSH commented 1 year ago

This PR will add a new image_preview property to asset annotation.

Adding this property will signal chaise that we should show a preview below the uploader UI in recordedit. So I had to add a displayImagePreview API to assets that chaise will use.

I also changed the default ermrestjs display of assets to add the image preview in this case. Given that to make this work in a compact table you would need to add max-width, we decided to not add this by default in compact views.

Related issue: chaise#2284

RFSH commented 1 year ago

After discussing this, we decided to not change the default presentation of assets for now. So the latest change in this PR is removing those changes.

We also decided to change the annotation to allow context.