Closed RFSH closed 1 year ago
After discussing these changes, we decided to revert the extra changes I included in this PR.
While the change related to column heuristics is something we should do, we have to make sure we're doing it consistently for row-name as well. If possible, we would like to keep these two as close as possible.
And the change to allow sourcekey
inside source-definitions
requires more discussion.
In this PR,
sourcekey
support to allow changingentity
,aggregate
, andself_link
at the same time (#909).In #909 we talked about allowing source definitions to refer to other definitions like this
What I pushed is just a simple syntactic sugar to avoid copy/paste, and so when this source is used in a visible-column, there is not signal that it's using a different sourcekey. So It cannot properly do the path sharing. But if we want this to also properly handle path sharing, we would need to think more about it and decide how it should be done.