minimal support for text/html rendering of resources

informatics-isi-edu / hatrac

Simple object storage for collaborations

Apache License 2.0

3 stars 1 forks source link

minimal support for text/html rendering of resources #53

Closed robes closed 5 years ago

robes commented 5 years ago

How extensive should the unit tests be for this functionality? It might be easy to add unit tests that just poke at it and make sure it doesn't get a 500. It would be more involved to add unit tests that confirm the contents of the results since it require html parsing. I think it can be done (probably with the python xml library).

karlcz commented 5 years ago

I don't think it needs much. There are a couple tests in rest-smoketests which set "Accept: text/uri-list" and I think equivalent tests for HTML would be sufficient. Those tests don't bother to validate the response, and I wouldn't bother for HTML either since the feature is so simple as long as the basic protocol and name resolution stuff is working...

robes commented 5 years ago

travis ci seems to be taking a while to run the tests, but they passed for me running against a dev host.