search

informatics-isi-edu / openseadragon-viewer

2D viewer with openseadragon
Apache License 2.0
5 stars 2 forks source link

Black screen on some images on rbk-dev #11

Closed svoinea closed 4 years ago

svoinea commented 4 years ago

I have tested random some images for the current master version on rbk-dev and some images are black.

See for example the differences on rbk-dev and rbk-www for these two cases:

carlkesselman commented 4 years ago

Do we know why?

Carl

Dr. Carl Kesselman Dean’s Professor, Epstein Department of Industrial and Systems Engineering Fellow, Information Sciences Institute Viterbi School of Engineering Professor,

Preventive Medicine Keck School of Medicine

University of Southern California 4676 Admiralty Way, Suite 1001, Marina del Rey, CA 90292-6695 Phone: +1 (310) 448-9338 Email: carl@isi.edu Web: http://www.isi.edu/~carl On Feb 29, 2020, 1:40 AM +0100, svoinea notifications@github.com, wrote:

I have tested random some images for the current master version on rbk-dev and some images are black.

See for example the differences on rbk-dev and rbk-www for these two cases:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/openseadragon-viewer/issues/11?email_source=notifications&email_token=AA3OGXTWBNGJVZTTE7ZNOP3RFGVIBA5CNFSM4K6EV24KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IRIR26Q, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA3OGXX3MM3Q5T5ZONKKGMLRFGVIBANCNFSM4K6EV24A.

vipul-21 commented 4 years ago

Yes, I did find the reason for the jpg file. We were not handling the case for simple files in the new code. I am still working on the czi file issue.

On Sat, Feb 29, 2020 at 4:50 AM Carl Kesselman notifications@github.com wrote:

Do we know why?

Carl

Dr. Carl Kesselman Dean’s Professor, Epstein Department of Industrial and Systems Engineering Fellow, Information Sciences Institute Viterbi School of Engineering Professor,

Preventive Medicine Keck School of Medicine

University of Southern California 4676 Admiralty Way, Suite 1001, Marina del Rey, CA 90292-6695 Phone: +1 (310) 448-9338 Email: carl@isi.edu Web: http://www.isi.edu/~carl On Feb 29, 2020, 1:40 AM +0100, svoinea notifications@github.com, wrote:

I have tested random some images for the current master version on rbk-dev and some images are black.

See for example the differences on rbk-dev and rbk-www for these two cases:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub< https://github.com/informatics-isi-edu/openseadragon-viewer/issues/11?email_source=notifications&email_token=AA3OGXTWBNGJVZTTE7ZNOP3RFGVIBA5CNFSM4K6EV24KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IRIR26Q>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AA3OGXX3MM3Q5T5ZONKKGMLRFGVIBANCNFSM4K6EV24A>.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/informatics-isi-edu/openseadragon-viewer/issues/11?email_source=notifications&email_token=ACBTW6P336UNI2SJSRTMCT3RFECDHA5CNFSM4K6EV24KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENLZJ4Y#issuecomment-592942323, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBTW6KRBCYMAYB5WY7ZP43RFECDHANCNFSM4K6EV24A .

carlkesselman commented 4 years ago

This is a czi file converted to pyramid tiff and running out of the image server?

Carl

Dr. Carl Kesselman Dean’s Professor, Epstein Department of Industrial and Systems Engineering Fellow, Information Sciences Institute Viterbi School of Engineering Professor,

Preventive Medicine Keck School of Medicine

University of Southern California 4676 Admiralty Way, Suite 1001, Marina del Rey, CA 90292-6695 Phone: +1 (310) 448-9338 Email: carl@isi.edu Web: http://www.isi.edu/~carl On Feb 29, 2020, 3:13 PM -0800, Vipul Singh notifications@github.com, wrote: Yes, I did find the reason for the jpg file. We were not handling the case for simple files in the new code. I am still working on the czi file issue.

On Sat, Feb 29, 2020 at 4:50 AM Carl Kesselman notifications@github.com wrote:

Do we know why?

Carl

Dr. Carl Kesselman Dean’s Professor, Epstein Department of Industrial and Systems Engineering Fellow, Information Sciences Institute Viterbi School of Engineering Professor,

Preventive Medicine Keck School of Medicine

University of Southern California 4676 Admiralty Way, Suite 1001, Marina del Rey, CA 90292-6695 Phone: +1 (310) 448-9338 Email: carl@isi.edu Web: http://www.isi.edu/~carl On Feb 29, 2020, 1:40 AM +0100, svoinea notifications@github.com, wrote:

I have tested random some images for the current master version on rbk-dev and some images are black.

See for example the differences on rbk-dev and rbk-www for these two cases:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub< https://github.com/informatics-isi-edu/openseadragon-viewer/issues/11?email_source=notifications&email_token=AA3OGXTWBNGJVZTTE7ZNOP3RFGVIBA5CNFSM4K6EV24KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IRIR26Q>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AA3OGXX3MM3Q5T5ZONKKGMLRFGVIBANCNFSM4K6EV24A>.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/informatics-isi-edu/openseadragon-viewer/issues/11?email_source=notifications&email_token=ACBTW6P336UNI2SJSRTMCT3RFECDHA5CNFSM4K6EV24KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENLZJ4Y#issuecomment-592942323, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBTW6KRBCYMAYB5WY7ZP43RFECDHANCNFSM4K6EV24A .

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/openseadragon-viewer/issues/11?email_source=notifications&email_token=AA3OGXUAV4GMYTXCGCMTQPDRFGLCZA5CNFSM4K6EV24KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENMIPTY#issuecomment-593004495, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA3OGXR2VR6CMHQVSIJDK73RFGLCZANCNFSM4K6EV24A.

vipul-21 commented 4 years ago

I need to check that.

carlkesselman commented 4 years ago

Please do. I don’t think we should spend any time debugging the old pipeline.

Carl

Sent from my iPhone

On Feb 29, 2020, at 3:23 PM, Vipul Singh notifications@github.com wrote:



I need to check that.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/openseadragon-viewer/issues/11?email_source=notifications&email_token=AA3OGXW3H5QKW7RFZ5JOP3DRFGMHNA5CNFSM4K6EV24KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENMIUZI#issuecomment-593005157, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA3OGXXM6DXF7VH4HOGFGU3RFGMHNANCNFSM4K6EV24A.

hongsudt commented 4 years ago

@svoinea Is this still an issue?