Closed vipul-21 closed 4 years ago
Changes are good overall, just found some minor differences when I tested the cases.
[Zoom and Pan]
[Scale bar]
[Screenshots]
[Multi-channels]
All these issues need to be addressed especially the scale bar..
Under zoom and pan, we should figure out why the thumbnail is shown; but more importantly the color in the thumbnail is different from the actual image.. This is bad since it is confusing.
From: MingYi Lin notifications@github.com Sent: Thursday, March 26, 2020 3:06 PM To: informatics-isi-edu/openseadragon-viewer openseadragon-viewer@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [informatics-isi-edu/openseadragon-viewer] Merging the codes (#12)
Changes are good overall, just found some minor differences when I tested the cases.
[Zoom and Pan]
thumbnail shown in the current version, but not in the staging version(Not sure if this is an issue)
[Scale bar]
Scalebar is shown in the staging version, not in the current version
[Screenshots]
changes are good. It works as in the staging version
[Multi-channels]
when I adjust the contrast to 80, it doesn't seem to have same effect as in the staging version
Current Version : https://dev.gudmap.org/~mingyi/chaise/viewer/#2/Gene_Expression:Image/id=16-2GM0?waterMark=gudmap.org [image]https://user-images.githubusercontent.com/14816171/77697917-f3767800-6f6c-11ea-9f94-3ea1177e2e1c.png
Staging Version : https://staging.gudmap.org/chaise/viewer/#2/Gene_Expression:Image/id=16-2GM0?waterMark=gudmap.org [image]https://user-images.githubusercontent.com/14816171/77697887-e5c0f280-6f6c-11ea-9c8a-883a02c5d7f4.png
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/openseadragon-viewer/pull/12#issuecomment-604711513, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AADFIDFCWVMYF63OERH27M3RJPGVRANCNFSM4LTDYFXQ.
I've updated the PR.
I have tested the cases specified on the wiki https://github.com/informatics-isi-edu/chaise/wiki/Viewer-regression-tests page using my home public_html
directory with:
annotation-list
master
multiple-annotations
Two cases need attention:
#2
: It seems that for the tiff
files, zoom in/out is not working for the mouse button clicks (https://dev.rebuildingakidney.org/~serban/chaise/viewer/#2/Gene_Expression:Image/id=14-3RDT?waterMark=gudmap.org)#13
: It seems that the meterScaleInPixels
from the URL does not overwrite the one specified in the metadata (the ImageProperties.xml
file) - (https://dev.gudmap.org/~serban/chaise/viewer/#2/Gene_Expression:Image/id=14-47ZA?meterScaleInPixels=35119000 - expected the scalebar to show 100 µm
; it is showing 1 mm
). On rbk-www
, the value in the ImageProperties.xml
is 3082824.615385
and the scalebar is showing 1 mm
.@svoinea The case #2
: I've fixed the situation.
case #13
: I checked the production, it seems to work in the same manner here as well.
I have retested issues #2
and #13
and they work as expected.
@hongsudt I have updated the PR with the cross on the channel list.
I have applied the latest changes on my public_html
directory and the test case #29
looks good to me.
Test case #31
remains open, the channel button remaining enabled, and showing No channels found
when you click it.
This PR is dependent on the chaise PR. It resolves the issues #11. Test cases : https://github.com/informatics-isi-edu/chaise/wiki/Viewer-regression-tests