Closed RFSH closed 4 years ago
I've pushed the refactored code on the OSD branch name refactored
. Since viewer app needed some changes with respect to these changes, there is a branch name refactored
on chaise as well that aligns with the osd changes.
@RFSH close this issue after the code is merged.
Over the last year, the repository has gone through a process of upgrading and it was almost rewritten. While working on the upgrade, the old code wasn't touched to be able to test the old features and make sure the new implementation is not removing any features.
Now it's the time to do some cleanup and separate the old files. Going forward, only the upgraded version should be used by deployment. We can keep the old files for future references but shouldn't be easily accessible. In the following I will list the changes that I think we should make:
pview.html
as it's not used at all.pview.html
and replace it withmview.html
.mview.html
and all of itsfonts
,js
, andcss
dependencies to a folder calledold_viewer
.mview.html
. Don't move the ones that are used byindex.html
.old_viewer/mview.html
is functional. You might need to modify thesrc
andhref
of these dependencies after moving.vendor
files that are used byindex.html
.index.html
tomview.html
.mview.html
. By making this change, we'll make sure that the new code is always used.sample#.png
files.This is a work in progress. I will update the issue based on the new findings