search

informatics-isi-edu / openseadragon-viewer

2D viewer with openseadragon
Apache License 2.0
5 stars 2 forks source link

Screenshot #9

Closed vipul-21 closed 4 years ago

vipul-21 commented 4 years ago

This PR includes the screenshot of the scene with the svg overlay. @svoinea The code for adding the watermark at the bottom left of the screenshot and the scale has been modified. I have commented some part of it. Please do take a look at it.

svoinea commented 4 years ago

I have tested on rbk-dev with:

chaise_pull_checkout annotation-list
openseadragon_pull_checkout Screenshot
chaise_install
openseadragon_install

I have tested a czi and a tif file.

In both I see the Show Annotations and Show Channels menus disabled. Is it intentionally?

The Take a Screenshot for the tif file does not work (the file is not saved). It adds just the watermark as you can see in:

tiff

For the czi file, the file can be saved: czi

I'm not sure if the position of the watermark in both the tif and czi files is the right one.

vipul-21 commented 4 years ago

@svoinea Updated the PR. 1) The Show Annotations and Show Channels menus were disabled because there were no annotations or channels to show for. 2) I have fixed tiff screenshot. 3) The position of watermark is also fixed. Also, since there are no available annotation on the dev server currently, this is the link for the screenshot with svg overlay.

svoinea commented 4 years ago

I have tried again the test on rbk-dev with the chaise annotation-list and openseadragon Screenshot branches.

For the *.tiff files, the download still seems not working.

The watermark should be placed on the bottom left corner of the viewer. As far as I know, that was a requirement. See in the below screenshots the differences between the watermark on rbk-dev and rbk-www: 14-47WE_dev

14-47WE_www

Also, it seems that the scalebar has disappeared from the screenshot.

I don't know what you mean by no channels. The .czi file with the RID=14-47WE has for example a channel.

Also, if there are no annotations, should it not be an option to create new annotations?

vipul-21 commented 4 years ago

@svoinea I am trying to fix the screenshot issue. Can we please try and merge this PR. This PR does not have the new screenshot feature.

vipul-21 commented 4 years ago

@svoinea I've updated the code. Following are the links which were tested:

  1. Tiff images with svg overlay
  2. Tiff images with watermark
  3. Tiff images without watermark
  4. CZI images with watermark
  5. CZI images without watermark

The screenshot for the above mentioned scenarios is working fine. Regarding other issues mentioned in above comments: 1) Channel list visibility issue- resolved in this PR. 2) Scale bar not present in the screenshot - resolved in this updated PR. 3) @hongsudt If there are no annotations, should it not be an option to create new annotations ?

svoinea commented 4 years ago

Please double check with @hongsudt:

My understanding is:

vipul-21 commented 4 years ago

@svoinea Can you please share the details of the browser and OS you're seeing the issue for second example. In my browser(chrome Version 79.0.3945.130), it is working fine.

svoinea commented 4 years ago

@vipul-21 It happens on Linux with Firefox version 68. I'm not sure why on my MAC with Chrome version 79, I'm getting a Network error while clicking the Take a Screenshot button.

vipul-21 commented 4 years ago
rastogi-bhavya commented 4 years ago

While performing regressing testing(https://github.com/informatics-isi-edu/chaise/wiki/Viewer-regression-tests#thumbnail-should-be-visible-based-on-file-type) on this branch I had some doubts and issue. Need some help with these:

carlkesselman commented 4 years ago

Scale bar is something we have had issues with before and configuration will depend on correct metadata. Would be good to sort through and make sure that is it behaving properly in all cases, and to be clear what it means to behave properly. So view this all with some suspicion!

Carl

Dr. Carl Kesselman Dean’s Professor, Epstein Department of Industrial and Systems Engineering Fellow, Information Sciences Institute Viterbi School of Engineering Professor,

Preventive Medicine Keck School of Medicine

University of Southern California 4676 Admiralty Way, Suite 1001, Marina del Rey, CA 90292-6695 Phone: +1 (310) 448-9338 Email: carl@isi.edu Web: http://www.isi.edu/~carl On May 20, 2020, 3:19 PM -0700, Bhavya Rastogi notifications@github.com, wrote:

While testing this branch I had some doubts and issue. Need some help with these: 4,5 - what is a thumbnail Scalebar - what does it look like? 8 - the scalebar is showing where as the testcase says that it shouldn't 9 - the scale shows 1µm instead of 50µm 12 - scalebar show 1 mm instead of 2mm 13- unclear what is mean? what is attribution? 17,18,19 - what does it mean? 21,24 - scale not coming in the screenshot 28 - scale shown 29, 30 - not working with my username (404 error) 32 - does annotation button mean show/hide annotation, need a link for an image with no annotations Issue - show annotation -> highlight annotation -> hide annotation ==> the highlight annotation is still active. Should the highlight annotation be deselected? "Under all Display = All situation, when users click the hide button of an item, the annotation should disappear on the openseadragon-viewer and the item should remain emphasized and the eye icon should be crossed out" what does this mean? 39 - the 'X' button is not placed properly 41 - Issue - click show all -> hide anyone of the annotations ==> should the "show all" still be ticked?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/informatics-isi-edu/openseadragon-viewer/pull/9#issuecomment-631757958, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA3OGXSZTOWTP3Z4BRI3VJ3RSRJNNANCNFSM4J64SBLA.