search

informatics-isi-edu / synspy

Synaptic segmentation and visualization with fluorescence microscopy
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Corrupt cached download is not repaired #11

Closed BDemps closed 7 years ago

BDemps commented 7 years ago

When attempting to launch this file (SynImgZfDsy20170316A6B), the program crashes with a list of error messages (attached below). Note that even if I download the file manually and put it into the folder where the launcher looks (Arnoldlab->synspy), the program still crashes.

The file is not corrupt (it opens fine if I use synspy-viewer on my own), and it definitely exists on the data management system. Also, there is plenty of room on the hard drive. image

karlcz commented 7 years ago

We observed that a failed download left a partial file in the cache and subsequent runs blindly tried to use this cached file rather than downloading again. Manually removing the bad file from the cache allowed the app to recover.

mikedarcy commented 7 years ago

Commit faf712e addresses this by removing any corrupted or partial downloads after the failure condition is caught. Looking into adding additional cache coherency checks before launch in the case that files get corrupted outside of the application.

karlcz commented 7 years ago

@mikedarcy are you planning to do more work on this or should we close it as it is?

mikedarcy commented 7 years ago

I'm planning on adding additional checks for coherency before launching. These changes will likely be folded into the more broadly scoped release of the 2d viewer functionality.