search

informatics-lab / cssp_china_wp5.6_binder

0 stars 0 forks source link

Dynamics vertical #7

Closed nathan962 closed 1 year ago

nathan962 commented 1 year ago

The code for the cross section of the dynamics

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

kaedonkers commented 1 year ago

Clear, well explained notebook. Some tidying of the narrative needed, but that can be done in future iterations (I think once we've got most of the notebooks on the repo and decide on a style).

Not happy to merge until the data directories are pointed at the data folder in this repo instead of the hardcoded DATADIR location you are currently using. Happy to commit after that.

nathan962 commented 1 year ago

@kaedonkers apologies this took so long!

Requested changes complete, if you spot anything else let me know.

Feel free to merge if it's ready

kaedonkers commented 1 year ago

Looks good to me! I'll merge it :)