informatics-lab / precip_rediagnosis

Project to use ML to re-diagnose precipitation fields from ensemble model fields
0 stars 0 forks source link

restore model rainfall max and amount fields to the output dataset #80

Closed stevehadd closed 1 year ago

stevehadd commented 1 year ago

in the refactoring of PR #39 , some of the model data fields that were being extracted were accidentally deleted when the decision was made to longer include model accumulations in the final dataset. These fields should be put back into the event configs:

stevehadd commented 1 year ago

actually i think I got confused. These variable are actually relating to 3 hour accumulations, even though the variable name in the cube metadata doesn't mention this. I just confused myself, these are taken out deliberately, so I will close this issue. @hannahbrown7 I assume you will be updating the EDA notebooks at some point so that plots from accumulations are removed, or maybe just optional ?