search

informatikr / hedis

A Redis client library for Haskell.
http://hackage.haskell.org/package/hedis
BSD 3-Clause "New" or "Revised" License
327 stars 121 forks source link

Support GHC 9 #171

Closed parsonsmatt closed 3 years ago

parsonsmatt commented 3 years ago

Closes #170

GHC 9 made parsing for a few symbols like # and ! more strict. Previously, !i would parse as an expression if the BangPatterns extension was not enabled, and fail with a pattern parse error if it was. GHC 9 makes it consistent by failing to parse regardless of whether or not the extension is on.

Depends on https://github.com/vincenthz/hs-memory/issues/84 and https://github.com/haskell-crypto/cryptonite/pull/338 as documented by the cabal.project file.

parsonsmatt commented 3 years ago

thanks!

parsonsmatt commented 3 years ago

could we get a release of this soon? it is the last thing blocking a GHC 9 compatible release of persistent.

k-bx commented 3 years ago

@parsonsmatt apologies, released as 0.14.3

k-bx commented 3 years ago

@parsonsmatt do you get this error by any chance?

$ cabal build
Cloning into '/home/kb/workspace/hedis/dist-newstyle/src/cryptonite-d41f2719b3d8d84c'...
remote: Enumerating objects: 7286, done.
remote: Counting objects: 100% (168/168), done.
remote: Compressing objects: 100% (109/109), done.
remote: Total 7286 (delta 90), reused 102 (delta 55), pack-reused 7118
Receiving objects: 100% (7286/7286), 2.07 MiB | 1.49 MiB/s, done.
Resolving deltas: 100% (5079/5079), done.
fatal: reference is not a tree: c5b2630ac396ad2d14ee1ed5d216907acaf2e79e
parsonsmatt commented 3 years ago

Oh, shoot! I think that branch for cryptonite may have been deleted. But the hackage release should work now, so deleting those source-repository-packages out of the cabal.project file should work.

Thanks for the release! 😄

k-bx commented 3 years ago

Gotcha. Released as 0.14.4 just in case