First I attempted to add the clientId command via the commands.json and codegen/GenCmds.hs infrastructure when I realized it hasn't been run for quite some time and re-running it (which itself would require quite a lot of changes) would overwrite (read remove) the stream and cluster commands and lot of other manual modifications made since quite long ago.
Since the comment in TODO.md mentioned this code generation functionality was to be removed anyway I went ahead and removed it. (Getting it into workable state would be quite a work - bringing the commands.json on par with the current Commands.hs, making sure the script even compiles (dependencies), .... with questionable benefits). A follow up work would be to merge the ManualCommands.hs with Commands.hs as from now on all commands are "manual".
With this out of the way, I went ahead and added clientId command fixing #145 :-)
qnikst
commented
1 year ago
First I attempted to add the
clientIdcommand via thecommands.jsonandcodegen/GenCmds.hsinfrastructure when I realized it hasn't been run for quite some time and re-running it (which itself would require quite a lot of changes) would overwrite (read remove) the stream and cluster commands and lot of other manual modifications made since quite long ago.Since the comment in
TODO.mdmentioned this code generation functionality was to be removed anyway I went ahead and removed it. (Getting it into workable state would be quite a work - bringing the commands.json on par with the currentCommands.hs, making sure the script even compiles (dependencies), .... with questionable benefits). A follow up work would be to merge theManualCommands.hswithCommands.hsas from now on all commands are "manual".With this out of the way, I went ahead and added
clientIdcommand fixing #145 :-)