Integration/pno

[jmwhorton]

Additions and updates for the integration of PNO terms into IAO: (issue: #237 )

Added IAO:0020000 identifier. Added IAO:0020001 grapheme. Added IAO:0020010 identifier creating process. Added IAO:0020015 personal name. Added IAO:0020016 given name. Added IAO:0020017 family name. Added IAO:0020020 code set. Moved IAO:0000579 (centrally registered identifier registry) under 'code set'.

[zhengj2007]

All edits look good to me except 'family name' and 'given name'. Both of them are subClass of 'personal name' and also part_of 'personal name'. Does not seem correct.

[jmwhorton]

Per conversation with @zhengj2007 and @mbrochhausen, 'family name' and 'given name' have been updated. Please let me know if the new definition for 'family name' is acceptable (updated to reflect change in hierarchy).

[jmwhorton]

Changes have been made per the 2022-07-18 OBI call.

@alanruttenberg, I do have a question for you. Based on your provided definition of 'code set,' I left it under 'information content entity' because it was worded as such. Please, let me know if the final intention was to move 'code set' under 'data set,' and I can get that change made.

[alanruttenberg]

My recollection was that the discussion had it that it would not be under data set.

[jmwhorton]

@zhengj2007, the requested changes have been made. Thank you for your time.

1. IAO_0000233 has been added to all new and updated terms.
2. Personal, family, and given name definitions have been updated to correct format.
3. Utterance was removed per the 2022-07-18 OBI call. #237 has been updated to reflect decisions.
4. Family name was moved (per the 2022-07-18 OBI call) because it refers to the name of a family, and does not refer to a person (like a 'personal name'). A 'given name' refers to an individual person, making it still a subclass of 'personal name'. (This is to the best of my recollection. I would welcome a better explanation if I've misrepresented the reason here.)
5. 'Term editor' annotations have been added.

[jmwhorton]

@zhengj2007, the requested changes have been made. Thanks!

[jmwhorton]

Good afternoon, @cmungall. When you have a moment, we just need one more review on these changes before merging them. Thanks!

[mbrochhausen]

I think we agreed to have it be a sibling to data set.

On Wed, Jul 20, 2022 at 2:41 PM Alan Ruttenberg @.***> wrote:

My recollection was that the discussion had it that it would not be under data set.

— Reply to this email directly, view it on GitHub https://github.com/information-artifact-ontology/IAO/pull/256#issuecomment-1190681330, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACF6DLTRYKQ2OWX5Y4YSRG3VVBI53ANCNFSM5YVOK4SQ . You are receiving this because you were mentioned.Message ID: @.***>

[zhengj2007]

Hi @jmwhorton The changes have been reviewed during OBI call. There is no objection on the changes for few months. I think you can merge the changes into IAO.

[StroemPhi]

Hi, when can we expect this change to be released?

[zhengj2007]

I am going to make a new release as soon as possible.

[StroemPhi]

Thank you @zhengj2007 🚀