information-artifact-ontology / IAO

information artifact ontology
Creative Commons Attribution 4.0 International
78 stars 25 forks source link

259 add 'orcid identifier' #261

Closed StroemPhi closed 2 years ago

StroemPhi commented 2 years ago

This PR adds the class 'ORCID identifier' as a subclass of 'centrally registered identifier' (IAO:0000578) with the details provided in the related NTR issue (closes #259).

@zhengj2007 as I wrote in the issue comments, I took what I assume to be the next free ID (IAO_0000708). Having some documentation on what IDs are allowed to use for external contributions would be great for future external PRs. And my Protégé default is to use dc:creator insted of IAO:'term editor' for the attribution. Let me know, if this needs to be changed. I also had to do the edits in my texteditor, as saving it in Protégé would have caused a much bigger diff, due to its automatic sorting. Maybe you can do this automatic sorting with the next release, so contributing in the future will be easier?