information-artifact-ontology / ontology-metadata

OBO Metadata Ontology
Creative Commons Zero v1.0 Universal
19 stars 8 forks source link

Add some synonym types #124

Closed cthoyt closed 1 year ago

cthoyt commented 1 year ago

Related to #122 and https://github.com/information-artifact-ontology/ontology-metadata/issues/70

See template sheet in this PR at https://github.com/cthoyt/ontology-metadata/blob/add-synonym-types/src/templates/annotation_properties.tsv.

This PR also adds SSSOM mappings from these new terms to external vocabularies, specifically HP, in https://github.com/cthoyt/ontology-metadata/blob/add-synonym-types/src/ontology/components/omo-to-external.tsv

matentzn commented 1 year ago

oh I should have told you that beforehand, sorry about that: https://github.com/information-artifact-ontology/ontology-metadata/blob/master/src/templates/annotation_properties.tsv

Forget we did that.. This template ensures we capture all necessary metadata in the right form;

I will see that I can prioritise finding Chris time for this because the first PR should be reviewed by he man himself. Just so we don't regret it later.

cthoyt commented 1 year ago

@matentzn i have now properly filled out the sheet so the appropriate ODK release commands can be used to turn the template into terms. should I do this in this PR, or it will get taken care of during release?

matentzn commented 1 year ago

I will take it from here!

cthoyt commented 1 year ago

There are already a few exact property matches I want to encode in this PR from human phenotype ontology:

Whats the best way to do this?

matentzn commented 1 year ago

I will encourage HPO to swap theirs out once this PR is in.

cthoyt commented 1 year ago

Either way, there will be artifacts of these in the wild for a long time until everyone has updated their HP imports. Wouldn't it be better to be defensive and plan for that situation?

matentzn commented 1 year ago

Yes, you are right of course. Probably best to keep such mappings in a separate sssom file rather than adding them to the source, because what we don't want is all these IRIs being added to the vocab..

cthoyt commented 1 year ago

Yes, you are right of course. Probably best to keep such mappings in a separate sssom file rather than adding them to the source, because what we don't want is all these IRIs being added to the vocab..

Added in https://github.com/cthoyt/ontology-metadata/commit/f188e8e6f29a9645322b35721f720aa918c81f96

matentzn commented 1 year ago

Nice!

matentzn commented 1 year ago

Let's go ahead but documented permitted synonym scopes, and provide a core omo-synonym release (these are notes to me myself)