search

information-artifact-ontology / ontology-metadata

OBO Metadata Ontology
Creative Commons Zero v1.0 Universal
19 stars 8 forks source link

Request for adding property symbol (IAO:0000028) to OMO #144

Closed anitacaron closed 3 months ago

anitacaron commented 11 months ago

IRI

http://purl.obolibrary.org/obo/IAO_0000028

Label

symbol

Definition of the property

An information content entity that is a mark(s) or character(s) used as a conventional representation of another entity.

Parent property

No response

What is the range of the property in question?

xsd:string

Examples of use

a serial number such as "12324X"; a stop sign; a written proper name such as "OBI"

Motivation to add

This is officially a class in IAO, and we're using it as an annotation in CL. We imported IAO and added the annotation type definition. However, people are having problems loading the CL ontology using owlready2 0.38. Check issue https://github.com/obophenotype/cell-ontology/issues/2080

ORCID, ROR or Wikidata identifier of the contributor

https://orcid.org/0000-0002-6523-4866

OMO Checklist

matentzn commented 11 months ago

@zhengj2007 what is the process of adding IAO terms to OMO?

Are they imported and the source of truth stays with IAO, or are they adopted and OMO becomes the new source of truth?

zhengj2007 commented 10 months ago

@matentzn Sorry I missed the notification. For the IAO terms moved to OMO, we just removed the terms from the IAO and added them in the OMO. The terms don't have 'import from' annotation property. But it needs to update the purl redirect to link the term to the OMO rather than the IAO. James helped on it. I made the IAO release just after each OMO release for consistency.

matentzn commented 10 months ago

Thanks @zhengj2007

For this specific term, is it ok to migrate it then from IAO to OMO?

zhengj2007 commented 10 months ago

@matentzn I am fine with it. Please let me know when you make the OMO release, then I will remove the term and make IAO release. Thanks!

matentzn commented 10 months ago

@anitacaron I wont get to this any time soon, feel free if this is important to you to add the term by yourself, including all metadata from IAO.

zhengj2007 commented 3 months ago

Sorry for missing the details of the request. I don't think it is correct to move an IAO class to OMO as an annotation property.

I think there is the need to have 'symbol' class. And the term has some subclasses and been widely used. If we need an annotation property 'symbol'. I propose to add a new annotation property and use other label, such as, 'has symbol'.

@anitacaron @matentzn

anitacaron commented 3 months ago

I agree with your solution, @zhengj2007. Which OMO ID should I create it?

zhengj2007 commented 3 months ago

@anitacaron I checked the OMO by opening omo-edit.owl using protege. Some ID ranges have been assigned to some editors and OBO Foundry Committee.

I think you may add your name and assign an ID range to yourself. But it would better to check with @matentzn.