search

information-artifact-ontology / ontology-metadata

OBO Metadata Ontology
Creative Commons Zero v1.0 Universal
19 stars 8 forks source link

Add brand name synonym type #162

Open cthoyt opened 10 months ago

cthoyt commented 10 months ago

Closes #148, noting caveats brought up by @hoganwr in https://github.com/information-artifact-ontology/ontology-metadata/issues/148#issuecomment-1745200569.

This synonym type is useful for ChEBI, see discussion on their tracker at https://gitlab.ebi.ac.uk/chembl/chebi/chebi-2.0/chebi-ontology-generator/-/issues/27

matentzn commented 10 months ago

Can we have this addressed first: https://github.com/OBOFoundry/OBOFoundry.github.io/issues/2450#issuecomment-1823043882

cthoyt commented 7 months ago

I'd like to try pushing this one more time. There are at least 5 ontologies that all have their own internal version of BRAND_NAME (chebi, fbbt, fbcv, and others that import chebi) because the synonyms don't get propagated in a nice way. I want to standardize all of these

matentzn commented 7 months ago

I cant help you push on this at the moment, so you may need to recruit some allies in slack.. Sorry about that.

hoganwr commented 7 months ago

I 100% support an annotation property in OMO called 'brand name' (we can do without caps and underscores).

I just don't think it is right to call it a "synonym type".

Bill

On Wed, Feb 21, 2024 at 5:30 AM Charles Tapley Hoyt < @.***> wrote:

I'd like to try pushing this one more time. There are at least 5 ontologies that all have their own internal version of BRAND_NAME (chebi, fbbt, fbcv, and others that import chebi) because the synonyms don't get propagated in a nice way. I want to standardize all of these

— Reply to this email directly, view it on GitHub https://github.com/information-artifact-ontology/ontology-metadata/pull/162#issuecomment-1956451480, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJR55XOIBYE3IL6O3UWEULYUXLFXAVCNFSM6AAAAAA7VJCDKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJWGQ2TCNBYGA . You are receiving this because you were mentioned.Message ID: <information-artifact-ontology/ontology-metadata/pull/162/c1956451480@ github.com>