informationsea / xlsxwriter-rs

Excel file writer for Rust
https://crates.io/crates/xlsxwriter
Apache License 2.0
265 stars 45 forks source link

Update upstream components and add basic support for writing cell comments #2

Closed mulark closed 4 years ago

mulark commented 4 years ago

I'm hopefully done messing about with it now. Initially I wanted to just add support for writing comments but then got a little carried away when it wouldn't build on 32bit Windows clang.

Currently write_comment_opt() is a stub because I wasn't sure how to sanely pass a mutable pointer of the stringy fields to lxw_write_comment_opt(). We could use null_mut() ptr to allow for some of the fields to be defined in the mean time.

Aside from that there's no significant issues that I know of.