informed-governance-project / NISINP

Incident Notification Platform by @NC3-LU
https://nisinp.readthedocs.io
GNU Affero General Public License v3.0
6 stars 3 forks source link

Multiple database management #6

Closed jerolomb closed 2 months ago

jerolomb commented 1 year ago

Describe the bug Actually the multiple database management is not take into account, everything is written in the default database specified in the configuration file

Expected behavior Multiple DB management working, maybe see for router and mapping in the config file :

DATABASE_ROUTERS = ['dbrouter']
DATABASE_APPS_MAPPING = {'incidents': 'incidents',
                        'governanceplatform':'governance'}

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

ruslanbaidan commented 1 year ago

I would suggest to go with a single database solution as:

  1. it simplifies join queries data selections as some tables are related (e.g. incidents_incident_affected_services and governanceplatform_services)
  2. There is no database level roles management of application users and all the permissions are implemented on the app level.
  3. App may work microseconds faster as has to keep a single standalone connection.
jerolomb commented 1 year ago

i think we can let the possibility to the users to do it if they want and provide the stuff but it's not an emergency

jerolomb commented 2 months ago

not needed anymore