search

infrabel / themes-gnap

Standardized build to produce web themes for use with GNaP.
http://gnap.io/
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Use ui-select instead of deprecated ui-select2 #134

Open vincentsels opened 9 years ago

vincentsels commented 9 years ago

The ui-select2 library (using select2) is deprecated and no longer maintained. They advise to use the ui-select library instead. This latter seems to have the select2 code included, instead of being depended on it. Of course, removing (ui-)select2 and replacing it with select, would be a breaking change, require a new major version of gnap, and migration instructions. Leaving the old one there for backward compatibility, on the other hand, would be a shame. Don't know what the 'vision' for this kind of deprecated libraries was for GNaP ;).

CumpsD commented 9 years ago

The vision was to keep a working set of libraries in GNaP and evaluate migration after a few years.

Personally, I would migrate all external libraries to become bower dependencies and bower-ise gnap instead of bringing in a bunch files via npm.