search

infrablocks / ruby_terraform

A simple Ruby wrapper for invoking terraform commands.
MIT License
109 stars 33 forks source link

Add logger #27

Closed jesusbv closed 5 years ago

jesusbv commented 5 years ago

Set logger to write stdout and log file Set default path and allow custom path Allow custom logger Update one test

jesusbv commented 5 years ago

Hi there,

First of all, thank you for the efforts on creating this wrapper.

I have made some changes to include a logger, in order to include more functionalities in this wrapper.

If accepted, I would update the rest of the tests for this PR.

tobyclemson commented 5 years ago

Hi Jesus,

Thanks for the PR, will be really useful to get this merged.

I've added a few notes inline in the PR that would be great to get addressed before merging.

Thanks, Toby

jesusbv commented 5 years ago

Thanks for the feedback Toby,

I have updated it accordingly, when all is good I can squash the commits into 1 before merge.

tobyclemson commented 5 years ago

Hi Jesus,

This looks good to me, if you could squash the commits, I'll merge it in.

As you mention it would be great to follow up with configurable standard streams and some extra tests for the other commands.

Thanks, Toby