search

infrablocks / ruby_terraform

A simple Ruby wrapper for invoking terraform commands.
MIT License
109 stars 33 forks source link

Make stdN configurable #28

Closed jesusbv closed 5 years ago

jesusbv commented 5 years ago

stdin, stdout and stderr can be set from the consumer

tobyclemson commented 5 years ago

Hey Jesus,

Thanks for this, it’s been requested by a few people so they’ll be pleased :)

I’ll get this merged in once I’m back at keyboard. It would be great to update the README and add some tests. I know the configuration stuff hasn’t really got tests there yet but even so.

Thanks, Toby

jesusbv commented 5 years ago

Hey Jesus,

Thanks for this, it’s been requested by a few people so they’ll be pleased :)

Yes, I thought to update the PR with the Fixes #N (13 I think)

I’ll get this merged in once I’m back at keyboard. It would be great to update the README and add some tests. I know the configuration stuff hasn’t really got tests there yet but even so.

No problem about the tests. The update of the README is in the to do list.

jesusbv commented 5 years ago

When approved, I would like to squash the commits into one before the merge

tobyclemson commented 5 years ago

Happy to merge, please go ahead and squash.

tobyclemson commented 5 years ago

Hey Jesus,

Sorry, I merged this prematurely. Don't worry about squashing the commits.

Thanks, Toby

jesusbv commented 5 years ago

Thanks ! Good that is merged. It's not that relevant for this PR, it would be nice to keep a clean, nice log

In case you wanted to squash them on master, running git rebase -i HEAD~1 would fix that.

tobyclemson commented 5 years ago

Looks like the configuration tests are failing, the merge failed through CI. I’m out all day today but can take a look this evening.

On Wed, 25 Sep 2019 at 11:34, Jesus Bermudez Velazquez < notifications@github.com> wrote:

Thanks ! Good that is merged. It's not that relevant for this PR, it would be nice to keep a clean, nice log

In case you wanted to squash them on master, running git rebase -i HEAD~1 would fix that.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/infrablocks/ruby_terraform/pull/28?email_source=notifications&email_token=AAAEAH53WQ3WYOXN3SDUH53QLMWCDA5CNFSM4IZMMAL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7RIHNI#issuecomment-534938549, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAEAH5AVGXZNAYRP2EU2Q3QLMWCDANCNFSM4IZMMALQ .

jesusbv commented 5 years ago

Fixed.

tobyclemson commented 5 years ago

Thanks. Will merge later.

On Wed, 25 Sep 2019 at 12:04, Jesus Bermudez Velazquez < notifications@github.com> wrote:

Fixed.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/infrablocks/ruby_terraform/pull/28?email_source=notifications&email_token=AAAEAH6JUX446FDZUSJWFLTQLMZSZA5CNFSM4IZMMAL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7RLD4Q#issuecomment-534950386, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAEAH7UDX5MRMKFOMBMDSDQLMZSZANCNFSM4IZMMALQ .

tobyclemson commented 5 years ago

Version 0.30.0 includes this change.