search

infrablocks / ruby_terraform

A simple Ruby wrapper for invoking terraform commands.
MIT License
109 stars 33 forks source link

Set logger to default value #29

Closed jesusbv closed 5 years ago

tobyclemson commented 5 years ago

Still have one failure but I'm gonna merge this in and update the tests. Thanks!

jesusbv commented 5 years ago

Weird. I know where the error comes from and how to fix it but...neither master nor the branch have it or are able to replicate it.

This should be level: :info so that test passes. Both, branch and master have it properly set.

tobyclemson commented 5 years ago

Hey Jesus,

The error is because the minimum supported version of Ruby for the library is 2.3.8 so I'm testing with that version and the particular constructor of Logger you were using was introduced after that version.

I've made some fixes locally and will push through and release a release version of the library shortly.

Thanks, Toby

tobyclemson commented 5 years ago

I've actually bumped the minimum supported version to 2.4.x now since 2.3 is no longer supported by the Ruby core team. You can see how I resolved the issues in master.

Version 0.30.0 includes this change.

jesusbv commented 5 years ago

I've actually bumped the minimum supported version to 2.4.x now since 2.3 is no longer supported by the Ruby core team. You can see how I resolved the issues in master.

Yes, I saw. Great.

Version 0.30.0 includes this change.

Good, now consumers can configure their streams, and the wrapper is more flexible.

tobyclemson commented 5 years ago

Good, now consumers can configure their streams, and the wrapper is more flexible.

Thanks for all your help!