Pre factoring

[sa73917]

A bunch of code cleanup in preparation for the command class refactoring.

• bundle update to get the new lino.
• improvement/cleanup of the shared examples introduced in the previous PR.
• rubocop automatic fixes, with a couple of cops / directories excluded (see commit msg for details).
• added simplecov as a dev dependency (in its own commit so can be dropped). I find it useful to be able bring up file:///ruby_terraform/coverage/index.html#_AllFiles and see what code isn't covered (it's not perfect, but better than nothing).

Worth noting that the simplecov minimum coverage limits in spec_helper.rb will throw exceptions in your CI build after rspec runs if new code goes in without tests but then I guess that's the point :-)

[tobyclemson]

All looks good to me.

It would be good to add rubocop to the precommit build. I'll add that shortly and update documentation for expected development workflow.

Thanks for this!

[sa73917]

All looks good to me.

It would be good to add rubocop to the precommit build. I'll add that shortly and update documentation for expected development workflow.

Thanks for this!

@tobyclemson I wouldn't add rubocop quite yet.. There are a lot that fail in the command classes. I didn't bother with those as yet - given I want to supply a PR with them completely re-written! :-)

[tobyclemson]

@sa73917 Ok I'll add the Rake machinery but hold off including in the precommit / CI until you've incorporated your other changes.

It would also be great if you could update the Development section of the README with your Guard workflow at some point.