search

infrae / pyoai

The oaipmh module is a Python implementation of an "Open Archives$ Initiative Protocol for Metadata Harvesting"
http://pypi.python.org/pypi/pyoai
Other
84 stars 53 forks source link

python3 compatibility #15

Closed tkurze closed 8 years ago

tkurze commented 8 years ago

Hi,

I changed a few imports and exception handling to achieve Python3 compatibility. I tested quickly against a local library repository and encountered no problems. I didn't ran any further tests though.

jascoul commented 8 years ago

Hi Tobias,

Thanks, that's awesome, looks great. I'll try to run some tests this week and then merge and do a pypi release

tkurze commented 8 years ago

Hi Jasper,

no problem. Glad I could help :)

On 01/27/2016 10:38 AM, Jasper Op de Coul wrote:

Hi Tobias,

Thanks, that's awesome, looks great. I'll try to run some tests this week and then merge and do a pypi release

— Reply to this email directly or view it on GitHub https://github.com/infrae/pyoai/pull/15#issuecomment-175511866.

jascoul commented 8 years ago

Hi,

I just merged your patch. I changed the code a bit to remove the six dependency, and some other minor issues. Can you test if this works for you on python3? I will do a pypi release soon.

tkurze commented 8 years ago

Hi,

OK. Cool.

I just ran my snippets with your code and everything seems fine to me :+1:

On 02/17/2016 12:19 PM, Jasper Op de Coul wrote:

Hi,

I just merged your patch. I changed the code a bit to remove the six dependency, and some other minor issues. Can you test if this works for you on python3? I will do a pypi release soon.

— Reply to this email directly or view it on GitHub https://github.com/infrae/pyoai/pull/15#issuecomment-185159332.