search

infraly / k8s-on-openstack

An opinionated way to deploy a Kubernetes cluster on top of an OpenStack cloud.
Apache License 2.0
112 stars 48 forks source link

Update ssh known_hosts handling #45

Closed emonty closed 5 years ago

emonty commented 5 years ago

There are three related changes here.

The first updates the master to be similar to the nodes and use lineinfile to add ssh keys to known_hosts instead of just shell redirection, otherwise known_hosts just grows over time.

The second updates nodes to use public ip instead of private ip with a proxy when auto_ip is True. This let's people who are intending to connect to those nodes directly from the machine they're running ansible from be set up to do so.

Finally, updated references to accesIPv4 to use public_v4 instead, as public_v4 is a stable interface from openstacksdk.

emonty commented 5 years ago

@ctrlaltdel The tests here are failing but it looks like a lack of openstack credentials in the test - is there something I should do about that?

ctrlaltdel commented 5 years ago

@emonty Yeah, this is a known issue, I haven't yet found a way to let travis access test credentials from pull requests (without much risks of them getting compromised...).

ctrlaltdel commented 5 years ago

Hmmm, looks like tests are failing now, See https://travis-ci.org/infraly/k8s-on-openstack/builds/490573781

emonty commented 5 years ago

@ctrlaltdel zomg. | bool can't handle False as an input. fix coming