search

infraly / k8s-on-openstack

An opinionated way to deploy a Kubernetes cluster on top of an OpenStack cloud.
Apache License 2.0
112 stars 48 forks source link

Bug in "add repos to helm" and "install helm charts" #54

Closed pfisterer closed 4 years ago

pfisterer commented 5 years ago

Hi all, I get the following errors/warnings when setting export INCLUDE_HELM="True" but w/o setting HELM_INSTALL:

TASK [k8s-addons : add repos to helm] 
Monday 07 October 2019  11:34:27 +0200 (0:00:02.257)       0:16:33.111 ********fatal: [test-master]: FAILED! =>
  msg: |-
    The conditional check 'item|length > 0' failed. The error was: error while evaluating conditional (item|length > 0): 'item' is undefined

    The error appears to be in 'k8s-on-openstack/roles/k8s-addons/tasks/helm.yaml': line 26, column 3, but may
    be elsewhere in the file depending on the exact syntax problem.

    The offending line appears to be:

    - name: add repos to helm
      ^ here
...ignoring

and

TASK [k8s-addons : install helm charts] 
Monday 07 October 2019  11:34:40 +0200 (0:00:07.961)       0:16:45.995 ********
fatal: [sturm-master]: FAILED! =>
  msg: |-
    The conditional check 'item|length > 0' failed. The error was: error while evaluating conditional (item|length > 0): 'item' is undefined

    The error appears to be in 'k8s-on-openstack/roles/k8s-addons/tasks/helm.yaml': line 42, column 3, but may
    be elsewhere in the file depending on the exact syntax problem.

    The offending line appears to be:

    - name: install helm charts
      ^ here
...ignoring
pfisterer commented 4 years ago

I've fixed this in my fork. A diff is available here.

If a PR is welcome, please let me know.