search

infro-io / issues

1 stars 0 forks source link

Diff comment not placed #7

Open rouke-broersma opened 8 months ago

rouke-broersma commented 8 months ago

I see that there is now a github action for placing the diff comments. Coincidentally my PRs no longer have diff comments, the diff is only visible in the PR check. Are we meant to now use the github action if we wish to have PR comments?

rouke-broersma commented 8 months ago

Mhm on the latest opened PR the comments are available..

No comment:

https://github.com/broersma-forslund/homelab/pull/199

But the check is green and contains a result:

https://github.com/broersma-forslund/homelab/pull/199/checks?check_run_id=22774600502

colethienes commented 7 months ago

Hmmm - I updated the logic to refresh the comment each time a PR is opened. If you get the chance, do you mind retrying?

rouke-broersma commented 7 months ago

I haven't seen this issue come up again, it might have had something to do with that specific commit. I moved that application to server side apply. In the check it looks like infro could not complete the diff, it didn't get further than cloudnative-postgres which is the app that contained the change. Not sure why it did get a partial check content though.

I think this might be pretty hard to replicate.